WIP: CI: Remove duplicated logic in host-ibm job#194
Closed
junaruga wants to merge 1 commit intoruby:masterfrom
Closed
WIP: CI: Remove duplicated logic in host-ibm job#194junaruga wants to merge 1 commit intoruby:masterfrom
junaruga wants to merge 1 commit intoruby:masterfrom
Conversation
Remove logic in host-ibm job, which is duplicated from the host job. I am using the YAML anchors and aliases feature to avoid the duplicated logic. The document is below. https://docs.github.com/en/actions/reference/workflows-and-actions/reusing-workflow-configurations#yaml-anchors-and-aliases
Member
Author
|
This is working in progress. I would like you to prioritize checking this PR than the PR #192. |
Member
|
Thanks but it seems that this is a bit complex to maintain... Let's keep the duplication for maintainability. |
Member
Author
|
Hmm, okay. I was trying to remove one of the 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove logic in host-ibm job, which is duplicated from the host job. I am using the YAML anchors and aliases feature to avoid the duplicated logic. The document is below.
https://docs.github.com/en/actions/reference/workflows-and-actions/reusing-workflow-configurations#yaml-anchors-and-aliases